Re: Building patch for MSYS2/MINGW32

[Richard Frith-Macdonald]

> On 1 Mar 2016, at 14:33, Richard Frith-Macdonald <address@hidden> wrote:
> 
> That makes me think that consolidating checks to all use  __MINGW__ was 
> probably a mistake.  Can we use the defines produced by the compiler instead?
> At the moment, for historic reasons (ie because of the versions of compilers 
> people used in the past) we map various defines to __MINGW__ and __WIN32__ to 
> say we are building on windows.
> Is there a single value common to all the current compilers that we can use 
> instead?  I think nowadays we probably only need to consider a modern gcc, a 
> modern clang, and microsoft's compiler; so if there's a common preprocessor 
> constant those compilers all define, we could switch to using that.
> Does anyone know?

Judging by what I can find with web searches, it seems that all the modern 
popular compilers define _WIN32 on ms-windows (and presumably _WIN64 if the 
system is 64bit).
Have my searches told me wrong?