gnustep-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gnustep-make: /etc/GNUstep.conf in case of --prefix and --sysconfdir


From: Ivan Vučica
Subject: gnustep-make: /etc/GNUstep.conf in case of --prefix and --sysconfdir
Date: Sun, 2 Apr 2017 16:19:02 +0000

Hey,

I'm trying to install GNUstep into /GNUstep with folders such as /GNUstep/System, /GNUstep/Local, etc. However, GNUstep.conf should live in /etc/GNUstep/GNUstep.conf.

  ./configure --prefix=/GNUstep --with-layout=gnustep --sysconfdir=/etc

Looks like sysconfdir is not used here. And in fact, GNUstep.conf ends up in /GNUstep/etc/GNUstep/GNUstep.conf, where it presumably won't be found by things trying to find where GNUstep is installed.

I'd like to submit this:

Index: configure.ac
===================================================================
--- configure.ac        (revision 40432)
+++ configure.ac        (working copy)
@@ -573,7 +573,7 @@
    Example: --with-config-file=/usr/GNUstep/GNUstep.conf
    By default, if this option is not specified, the config file is
    /etc/GNUstep/GNUstep.conf if the prefix is /, /usr or /usr/GNUstep
-   and $prefix/etc/GNUstep/GNUstep.conf otherwise.  On Apple, it is
+   and $sysconfdir/GNUstep/GNUstep.conf otherwise.  On Apple, it is
    always /Library/GNUstep/GNUstep.conf regardless of prefix.
 ],
   GNUSTEP_CONFIG_FILE="$withval",)
@@ -584,7 +584,7 @@
           x)             GNUSTEP_CONFIG_FILE=/etc/GNUstep/GNUstep.conf;;
           x/usr)         GNUSTEP_CONFIG_FILE=/etc/GNUstep/GNUstep.conf;;
           x/usr/GNUstep) GNUSTEP_CONFIG_FILE=/etc/GNUstep/GNUstep.conf;;
-          *)             GNUSTEP_CONFIG_FILE="$GNUSTEP_PREFIX/etc/GNUstep/GNUstep.conf";;
+          *)             GNUSTEP_CONFIG_FILE="$sysconfdir/GNUstep/GNUstep.conf";;
         esac ;;
   esac
 fi


Tests performed (note: I omitted --sysconfdir):

$ sudo -E make install
Creating system tools directory: /GNUstep/System/Tools
Creating makefile directories in: /GNUstep/System/Library/Makefiles
Installing GNUstep configuration file in /etc/GNUstep/GNUstep.conf
Installing gnustep-make support software
Installing makefiles
Installing Test Framework scripts
Installing Test Framework support files
Installing (and compressing) manpages

$ sudo -E make install DESTDIR=/tmp/bla
Creating system tools directory: /tmp/bla/GNUstep/System/Tools
Creating makefile directories in: /tmp/bla/GNUstep/System/Library/Makefiles
Installing GNUstep configuration file in /tmp/bla/etc/GNUstep/GNUstep.conf
Installing gnustep-make support software
Installing makefiles
Installing Test Framework scripts
Installing Test Framework support files
Installing (and compressing) manpages

Old behavior:

$ sudo -E make install
Creating system tools directory: /GNUstep/System/Tools
Creating makefile directories in: /GNUstep/System/Library/Makefiles
Installing GNUstep configuration file in /GNUstep/etc/GNUstep/GNUstep.conf
Installing gnustep-make support software
Installing makefiles
Installing Test Framework scripts
Installing Test Framework support files
Installing (and compressing) manpages


There is an alternative which _may_ be more correct, and would yield the old behavior. Namely, the documentation says this about --sysconfdir:

  --sysconfdir=DIR        read-only single-machine data [PREFIX/etc]

This sounds like --sysconfdir, if omitted, should already default to PREFIX/etc; in my case, /GNUstep/etc. What do you think? Should I change my patch to result in that behavior? I'd simply add $GNUSTEP_PREFIX/ before $sysconfdir.

I'm happy to switch to --with-config-file=/etc/GNUstep/GNUstep.conf, anyway.

Thoughts?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]