Re: [gpsd-dev] [PATCH] subframe decoding fixes

[Eric S. Raymond]

Alexey Illarionov <address@hidden>:
> The attached patch fixes decoding of several subframe fields:
> 
> sub1.l2 and sub1.af0 have wrong offsets
> sub2.M0 is 32bit signed
> sub3.Cid is 16bit signed
> sub3.IDOT is 14bit signed

The patch looks right, but some of those changes produce regression failures
in the code that reads subframes from SiRF GPSes.  Therefore I want to be
a bit careful about integrating it and be sure the casews you want fixed
are covered iun our test suite.  

Can you supply some RTCM3 test pairs? By that I mean pairs consisting of
binary RTCM3 sentences and full decodes of them in a human-readable textual
format.  Once I have those, I can (a) verify your changes, and (b) add those
pairs to the regression test for RTCM3, which currently only has one example
of type 1029 and one of 1005.

Ideally, I'd like to have at least one test pair for each RTCM3 type.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>