[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effec
From: |
Eric S. Raymond |
Subject: |
Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects |
Date: |
Tue, 5 Jun 2012 12:46:58 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
address@hidden <address@hidden>:
> These 5 patches make modifications to some code that affects other components.
> Scons check passed on each individual commit, so there shouldn't be any
> regression.
>
> - The first patch makes gpsdecode honor the unscaled flag, and fix SConstruct
> so that the tests are not affected.
> - The second one makes gpsd_hexdump() always dump in hexadecimal form (no more
> "maybe text, maybe hex" behaviour)
> - The third one increase the maximum json value length (AIS can produce "very"
> long strings)
> - The forth one adds a new talker ID: BS, which is used by some AIS
> basestation
> - The last one adds a simple script that can be used to check for JSON
> validity
Are these applied already? The all look good except the change to
hexdump behavior. It's written that way for a reason - otherwise we get
logfiles from NMEA devices that are unnecessarily obfuscated.
--
<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
- [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects, chris, 2012/06/05
- [gpsd-dev] [PATCH 5/5] Add script to test for JSON validity, chris, 2012/06/05
- [gpsd-dev] [PATCH 1/5] gpsdecode: honor scale flag, chris, 2012/06/05
- [gpsd-dev] [PATCH 2/5] gpsd_hexdump: Always dump in hex mode, chris, 2012/06/05
- [gpsd-dev] [PATCH 3/5] json.h: Change JSON_VAL_MAX from 120 to 512, chris, 2012/06/05
- [gpsd-dev] [PATCH 4/5] Add BS talker ID (used by AIS base stations), chris, 2012/06/05
- Re: [gpsd-dev] [PATCH 0/5] [AIS] Modifications with potential side effects,
Eric S. Raymond <=