Re: [gpsd-dev] Master branch fails valgrind audit

[address@hidden]

Hallo,

i may have introduced a bug a bug with that  commit 1ee8e4d601d: Move nowait 
out of gpsd_add_device.

-#ifdef FORCE_NOWAIT
     (void)ntpshm_init(&context, true);
-#else
-    (void)ntpshm_init(&context, nowait);
-#endif /* FORCE_NOWAIT */

It look for me now, that i have removed the wrong side of the #ifdef.

I will investigate this, and commit a patch soon.

Reinhard

-----Original-Nachricht-----
Von: Olivier Cornu <address@hidden>
An: gpsd-dev <address@hidden>
Cc: address@hidden
Betreff: Master branch fails valgrind audit
Datum: Sun, 22 Jul 2012 21:17:33 +0200

The master branch currently fails the valgrind audit with:

$ scons -c && scons && scons valgrind-audit
(...)
gpsd:WARN: exiting.
==2037==
==2037== HEAP SUMMARY:
==2037==     in use at exit: 272 bytes in 1 blocks
==2037==   total heap usage: 65 allocs, 64 frees, 11,690 bytes allocated
==2037==
==2037== 272 bytes in 1 blocks are possibly lost in loss record 1 of 1
==2037==    at 0x4C29DB4: calloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2037==    by 0x4012074: _dl_allocate_tls (dl-tls.c:297)
==2037==    by 0x559CABC: pthread_create@@GLIBC_2.2.5 (allocatestack.c:571)
==2037==    by 0x40810B: ntpd_link_activate (in /home/olivier/dev/gpsd/gpsd)
==2037==    by 0x407396: gpsd_add_device (in /home/olivier/dev/gpsd/gpsd)
==2037==    by 0x403A68: main (in /home/olivier/dev/gpsd/gpsd)
==2037==
==2037==
==2037== ---- Print suppression ? --- [Return/N/n/Y/y/C/c] ----
==2037== LEAK SUMMARY:
==2037==    definitely lost: 0 bytes in 0 blocks
==2037==    indirectly lost: 0 bytes in 0 blocks
==2037==      possibly lost: 272 bytes in 1 blocks
==2037==    still reachable: 0 bytes in 0 blocks
==2037==         suppressed: 0 bytes in 0 blocks
==2037==
==2037== For counts of detected and suppressed errors, rerun with: -v
==2037== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 2 from 2)
scons: done building targets.

I've bisected the issue back to commit 1ee8e4d601d: Move nowait out of
gpsd_add_device.
I haven't investigated any further.

Most likely, this has gone unnoticed thanks to bug #36919 [1]: "scons
valgrind-audit" does not audit local freshly-built gpsd instance.


Regards,

--
Olivier Cornu

[1] https://savannah.nongnu.org/bugs/?36919