Re: [gpsd-dev] [PATCH] handle multiple flags in a single variable

[Eric S. Raymond]

Mike Frysinger <address@hidden>:
> If you build with:
>       LINKFLAGS='-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=both' scons
> the current code fails because it parses these flags as a single argument
> instead of a space-delimited list of flags.  Make sure we split this value
> properly.
> ---
>  SConstruct |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/SConstruct b/SConstruct
> index 23d6f18..434b47c 100644
> --- a/SConstruct
> +++ b/SConstruct
> @@ -237,7 +237,7 @@ for i in ["AR", "ARFLAGS", "CCFLAGS", "CFLAGS", "CC", 
> "CXX", "CXXFLAGS", "STRIP"
>              env.Replace(**{j: os.getenv(i)})
>  for flags in ["LDFLAGS", "LINKFLAGS", "SHLINKFLAGS", "CPPFLAGS"]:
>      if os.environ.has_key(flags):
> -        env.MergeFlags({flags : [os.getenv(flags)]})
> +        env.MergeFlags({flags : Split(os.getenv(flags))})
>  
>  
>  # Keep scan-build options in the environment
> -- 
> 1.7.9.7
> 

I don't think this patch is quite right.  I've added LINKFLAGS to the 
immediately previous list of flags that get pre-split when they're
imported; please let me know if that works.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>