Re: [gpsd-dev] [PATCH] [RFC] gpsmon: add PPS monitoring at -D2 debug level

[Beat Bolli]

On 02.11.13 14:19, Eric S. Raymond wrote:
> Beat Bolli <address@hidden>:
>> This is a request for comment for adding PPS output to gpsmon, as seen
>> on Eric's TODO list.
>>
>> The patch works, but has two issues, IMO. Both are marked with "FIXME"
>> in the source:
>>
>> - I'm not sure about updating device->last_fixtime where it is now. It
>>   works but maybe there's a better place?
> 
> Probably this should be done somewhere in the generic PPS reporting loop
> itself, rather that requiring callers to manage it.  I'll look into it.
>  
>> - An allocated SHM segment has to be faked, otherwise
>>   pps_thread_activate() won't even start the thread.
> 
> Yeah, that's a structural bug.  It reveals that I haven't decoupled 
> the generic PPS stuff from the management of the SHM segment quite
> enough yet.  I will definitely fix this.
> 
>> A different issue is whether it's OK to output the PPS messages only at
>> -D2. Should they be visible at any debug level?
> 
> Yes.  See my reply to Greg Troxel.
> 
> I actually tried implementing this but failed because I didn't realize
> there was still a bad cohesion to the SHM allocation.  Good work noticing
> that.
> 

Thanks.

I'm working on locking now. ncurses is not thread-safe, isn't it? Then
it should be no problem to write to the packet window from pps_report,
regardless of the debug level.

Beat
-- 
mail: echo '<address@hidden>' | tr -d '[A-S]'
pgp: 0x506A903A; 49D5 794A EA77 F907 764F  D89E 304B 93CF 506A 903A
gsm: 4.7.7.6.0.7.7.9.7.1.4.e164.arpa
icbm: 47.0452 N, 7.2715 E

"It takes love over gold, and mind over matter" -- Dire Straits

signature.asc
Description: OpenPGP digital signature