gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 1/4] Allow multiple options in LINKFLAGS.


From: Mike Frysinger
Subject: Re: [gpsd-dev] [PATCH 1/4] Allow multiple options in LINKFLAGS.
Date: Fri, 22 Nov 2013 15:25:38 -0500
User-agent: KMail/1.13.7 (Linux/3.12.0; KDE/4.6.5; x86_64; ; )

i don't think this change is correct.  pretty sure you want this instead:

https://bugs.gentoo.org/391299

split up linking flags into multiple arguments

--- gpsd-3.8/SConstruct
+++ gpsd-3.8/SConstruct
@@ -214,7 +214,7 @@
             env.Replace(**{j: os.getenv(i)})
 for flag in ["LDFLAGS", "LINKFLAGS", "SHLINKFLAGS", "CPPFLAGS"]:
     if os.environ.has_key(flag):
-        env.MergeFlags({flag : [os.getenv(flag)]})
+        env.MergeFlags({flag : Split(os.getenv(flag))})
 
 
 # Placeholder so we can kluge together something like VPATH builds.

-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]