gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 1/4] Allow multiple options in LINKFLAGS.


From: Eric S. Raymond
Subject: Re: [gpsd-dev] [PATCH 1/4] Allow multiple options in LINKFLAGS.
Date: Sat, 23 Nov 2013 00:39:38 -0500
User-agent: Mutt/1.5.21 (2010-09-15)

Mike Frysinger <address@hidden>:
> i don't think this change is correct.  pretty sure you want this instead:
> 
> https://bugs.gentoo.org/391299
> 
> split up linking flags into multiple arguments
> 
> --- gpsd-3.8/SConstruct
> +++ gpsd-3.8/SConstruct
> @@ -214,7 +214,7 @@
>              env.Replace(**{j: os.getenv(i)})
>  for flag in ["LDFLAGS", "LINKFLAGS", "SHLINKFLAGS", "CPPFLAGS"]:
>      if os.environ.has_key(flag):
> -        env.MergeFlags({flag : [os.getenv(flag)]})
> +        env.MergeFlags({flag : Split(os.getenv(flag))})
>  
>  
>  # Placeholder so we can kluge together something like VPATH builds.
> 
> -mike

You know, now that I think about it, I think we've been around this
merry-go-round before, years ago.  Both versions work for me.  

Would you and Miroslav please argue this out and fix it? Then
add a comment explaining why it's done in whatever way is right
and warning against reverting to a wrong version.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]