Re: [gpsd-dev] Possile unneded code

[Sanjeev Gupta]

Gary,

I commented that function out to see what would break, and I see another issue now:

gcc -o driver_garmin.os -c -D_GNU_SOURCE -Wextra -Wall -Wno-uninitialized -Wno-missing-field-initializers -Wcast-align -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes -Wpointer-arith -Wreturn-type -pthread -Wmissing-prototypes -Wmissing-declarations -O2 -fPIC driver_garmin.c
driver_garmin.c:627:19: warning: 'PrintUSBPacket' defined but not used [-Wunused-function]
 static gps_mask_t PrintUSBPacket(struct gps_device_t *session, Packet_t * pkt)
                   ^

I will stop messing with it now ;-)

--
Sanjeev Gupta
+65 98551208     http://www.linkedin.com/in/ghane

On Sat, Nov 16, 2013 at 6:18 AM, Gary E. Miller <address@hidden> wrote:

Yo Eric!

On Fri, 15 Nov 2013 17:04:26 -0500
"Eric S. Raymond" <address@hidden> wrote:

> Sanjeev Gupta <address@hidden>:
> > While building:
> >
> > gcc -o driver_garmin.os -c -D_GNU_SOURCE -Wextra -Wall
> > -Wno-uninitialized -Wno-missing-field-initializers -Wcast-align
> > -Wmissing-declarations -Wmissing-prototypes -Wstrict-prototypes
> > -Wpointer-arith -Wreturn-type -pthread -Wmissing-prototypes
> > -Wmissing-declarations -O2 -fPIC driver_garmin.c
> >
> > driver_garmin.c:736:13: warning: 'Build_Send_USB_Packet' defined
> > but not used [-Wunused-function]
> >  static void Build_Send_USB_Packet(struct gps_device_t *session,
> >              ^
> >
> > This is on a Linux, so __linux__  should be defined.
>
> Gary's code; I'll let him field this one.

Somebody obsoleted that a while back.  Not sure how Garmin USB can work
wothout that.  I guess I better find some of my USB Garmin to test.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97701
        address@hidden  Tel:+1(541)382-8588