Re: [gpsd-dev] scons quirks

[Mike Frysinger]

On Wednesday 27 November 2013 04:17:37 Eric S. Raymond wrote:
> Mike Frysinger <address@hidden>:
> > i've sent some patches in the past to make chrpath=False work, but it
> > seems like a losing battle (current git master doesn't work 100% for
> > example).
> 
> Oh?  What fails?  I do wantr to make that case work.

simple use case:
$ scons -j5 prefix=/usr chrpath=False

when i look at the compiled objects, they've got rpaths on them and they 
shouldn't

when i try to install, i do:
$ DESTDIR=$PWD/foo scons -j5 prefix=/usr chrpath=False

the objects in foo/ now also have bad rpaths pointing to the destdir

the patch i've been using is attached.  i don't know if it's the right answer, 
but it fixes my problems.
-mike

don't set the -rpath flag to the install dir as this breaks DESTDIR

--- a/SConstruct
+++ b/SConstruct
@@ -287,7 +287,7 @@ def installdir(dir, add_destdir=True):
 # Honor the specified installation prefix in link paths.
 if env["sysroot"]:
     env.Prepend(LIBPATH=[env["sysroot"] + installdir('libdir', 
add_destdir=False)])
-if env["shared"]:
+if env["shared"] and env["chrpath"]:
     env.Prepend(RPATH=[installdir('libdir')])
 
 # Give deheader a way to set compiler flags

signature.asc
Description: This is a digitally signed message part.