Re: [gpsd-dev] [PATCH] Add TODO item to detangle TIOCMIWAIT and RFC2783.

[Gary E. Miller]

Yo Greg!

I jsut looked at the code.  Looks to me like we removed the TIOCMIWAIT
dependency from RFC2783 earlier this year.  The #if defined(TIOCMIWAIT)
looks in the right places to me.

But I'll accpet the non TIOCMIWAIT is not tested or not working.

On Tue, 26 Aug 2014 20:36:06 -0400
Greg Troxel <address@hidden> wrote:

> ---
>  TODO | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/TODO b/TODO
> index 4184320..0ea3dba 100644
> --- a/TODO
> +++ b/TODO
> @@ -37,6 +37,19 @@ confidence measure at a high level.  We'd use the
> confidence level to control (a) whether gpsd ships to NTP, and (b)
> how it sets time uncertainty in output JSON.
>  
> +*** RFC2783 bugs
> +
> +**** detangle TIOCMIWAIT and RFC2783
> +
> +Currently, the code for RFC2783 seems to depend (logically) on
> +TIOCMIWAIT support.  However, RFC2783 (and really, no standard)
> +defines TIOCMIWAIT, and NetBSD (and probably FreeBSD) do not
> implement +it.  So, there really should be two separate
> implementations, one that +works with TIOCMIWAIT (and thus only on
> Linux and OpenBSD) and one +that assumes only RFC2783 (and thus works
> on Linux, FreeBSD and +NetBSD, as well as any future system that
> complies with RFC2783 and +uses the serial port for time_pps_init).
> +
>  *** Client bugs
>  
>  **** In gpsmon's PPS Offset field




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97701
        address@hidden  Tel:+1(541)382-8588