[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] to improve the nice script

From: Beat Bolli
Subject: Re: [gpsd-dev] [PATCH] to improve the nice script
Date: Sun, 26 Oct 2014 16:01:14 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

On 26.10.14 15:17, Claus Klein wrote:
> Hi all
> while working with from GPSD project I added the missing
> option
>   -c generate a C initializer listing leap seconds in Unix gmt time.
> and a default action:
>   With no option, get the current GPS leap-second value.
> like this:
> *Claus-MacBook-Pro:gpsd clausklein$ ./*
> *Current leap seconds since 1980: 16, valid from 2012-06-30T23:59:59*
> *Claus-MacBook-Pro:gpsd clausklein$ *
> I checked my changes with pep8 and found a lot of warnings.
> I decided to fix this warnings too:
> Would you like to accept my patch?

Generally, one commit should only contain one change, so it would be
great if you could split this patch into two: one for the -c option, and
the secone one for PEP8 conformance. Then Eric can pick what he thinks
is OK. I think PEP8 conformance is not high on his list of priorities.

mail: echo '<address@hidden>' | tr -d '[A-S]'
pgp: 0x506A903A; 49D5 794A EA77 F907 764F  D89E 304B 93CF 506A 903A
icbm: 47.0452 N, 7.2715 E

"It takes love over gold, and mind over matter" -- Dire Straits

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]