gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Turn down the log level of the MTK ACKs


From: Beat Bolli
Subject: Re: [gpsd-dev] [PATCH] Turn down the log level of the MTK ACKs
Date: Mon, 23 Mar 2015 23:32:17 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 23.03.15 23:25, Gary E. Miller wrote:
> Yo Beat!
> 
> But a NACK is a warning.  That is in the NACK path.

Nope, the NACKs are above. This is the ACK, as the message says.

> 
> On Mon, 23 Mar 2015 23:20:35 +0100
> Beat Bolli <address@hidden> wrote:
> 
>> An ACK is no warning, so they can be logged with LOG_DATA.
>>
>> Signed-off-by: Beat Bolli <address@hidden>
>> ---
>>  driver_nmea0183.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/driver_nmea0183.c b/driver_nmea0183.c
>> index 46307ff..81e5878 100644
>> --- a/driver_nmea0183.c
>> +++ b/driver_nmea0183.c
>> @@ -1261,7 +1261,7 @@ static gps_mask_t processMTK3301(int c UNUSED,
>> char *field[], field[1], mtk_reasons[reason]);
>>      }
>>      else
>> -        gpsd_log(&session->context->errout, LOG_WARN,
>> +        gpsd_log(&session->context->errout, LOG_DATA,
>>                   "MTK ACK: %s\n", field[1]);
>>      return ONLINE_SET;
>>      case 424:                       /* PPS pulse width response */
> 
> 
> 
> 
> RGDS
> GARY
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97701
>       address@hidden  Tel:+1(541)382-8588
> 


-- 
https://drbeat.li
pgp: 0x506A903A; 49D5 794A EA77 F907 764F  D89E 304B 93CF 506A 903A
gsm: 4.7.7.6.0.7.7.9.7.1.4.e164.arpa
icbm: 47.0452 N, 7.2715 E

"It takes love over gold, and mind over matter" -- Dire Straits



reply via email to

[Prev in Thread] Current Thread [Next in Thread]