Re: [gpsd-dev] [PATCH] Fix build against musl libc

[Dave Taht]

On Tue, Jun 23, 2015 at 10:48 AM, Gary E. Miller <address@hidden> wrote:
> Yo Baruch!
>
> On Tue, 23 Jun 2015 09:12:01 +0300
> Baruch Siach <address@hidden> wrote:
>
>> musl does not include sys/ttydefaults.h from sys/termios.h. Include it
>> explicitly.
>
> Hmm.
>
> What is 'musl'?

Openwrt just switched their main libc from uclibc to musl, and is
coping with the breakage. (which is actually quite minimal,
surprisingly)

musl has a lot of nice attributes, notably it is more correct, and
safer, particularly where threads are concerned.

http://www.etalabs.net/compare_libcs.html

> Why do you need <sys/ttydefaults.h> ?  No other port needs it.
>
> How common is <sys/ttydefaults.h> ?  It is not POSIX-1:2001 (gpsd baseline).
>
> Can we really always expect it to be present?
>
> We'll need a test to see when we need this file and if it exists in the
> current system.

#if defined(MUSL) or some such?

> So with a little more info we can fix this for you.
>
> RGDS
> GARY
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
>         address@hidden  Tel:+1(541)382-8588
>
> On Tue, 23 Jun 2015 09:12:01 +0300
> Baruch Siach <address@hidden> wrote:
>
>> musl does not include sys/ttydefaults.h from sys/termios.h. Include it
>> explicitly.
>>
>> Fixes build failures like:
>>
>> gpsmon.o: In function `main':
>> gpsmon.c:(.text.startup+0x8f4): undefined reference to `CTRL'
>> ---
>>  gpsmon.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/gpsmon.c b/gpsmon.c
>> index c3001c865821..0ccf74110b5a 100644
>> --- a/gpsmon.c
>> +++ b/gpsmon.c
>> @@ -20,6 +20,7 @@
>>  #include <sys/types.h>
>>  #include <sys/stat.h>
>>  #include <sys/select.h>
>> +#include <sys/ttydefaults.h>
>>  #include <fcntl.h>
>>  #include <unistd.h>
>>
>
>
>
>
> RGDS
> GARY
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
>         address@hidden  Tel:+1(541)382-8588



-- 
Dave Täht
worldwide bufferbloat report:
http://www.dslreports.com/speedtest/results/bufferbloat
And:
What will it take to vastly improve wifi for everyone?
https://plus.google.com/u/0/explore/makewififast