|
From: | Jon Schlueter |
Subject: | Re: [gpsd-dev] Bug in JSON encoding AIVDM type 9 messages |
Date: | Mon, 5 Oct 2015 22:25:07 -0400 |
We seem to be missing any data samples that exercises this data path.Stefan Roels,Can I get a couple of data samples for the following cases.
Type 8, DAC = 1 FID = 11: airtemp, dewpoint and watertemp calculations go wrong due to unsigned ints.
- Type 8, DAC = 1 FID = 16: This should only be decoded as "Persons on board" if the message length is either 72 or 136 bits long (if even then).We seem to be missing any data samples that exercises the persons on board data flow It would be nice to make sure we don't regress backwards with other changes to the parser or storage logic.
- Type 8, DAC = 1 FID = 16: If decoded, the json output should use the ais->type8.dac1fid16.persons field and not the type6 field
- Type 9: the ais->type9.speed field should be used instead of the type1 fieldWe seem to be missing any data samples that exercise this test case where it fails. I'm going to apply the patch but would like to make sure we have test cases covering this data flow if we don't already have any.
Thanks much
Jonjschlueter on freenode #gpsd
[Prev in Thread] | Current Thread | [Next in Thread] |