[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH] [libgpsd-core] Fix regression from changing NMEA_
|
From: |
Eric S. Raymond |
|
Subject: |
Re: [gpsd-dev] [PATCH] [libgpsd-core] Fix regression from changing NMEA_ENABLE to NMEA0183_ENABLE |
|
Date: |
Fri, 22 Jan 2016 13:10:23 -0500 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
Michael Brown <address@hidden>:
> Commit 3e25e21 ("Address Savannah bug #46082 - Can't explicitly build
> with NMEA drivers.") performed an almost global search and replace of
> NMEA_ENABLE to NMEA0183_ENABLE. This search and replace caught the
> "#ifdef NON_NMEA_ENABLE" in gpsd_activate(), but missed the
> corresponding "#define NON_NMEA_ENABLE" in gpsd.h-tail. The end
> result is that devices requiring active probing (e.g. Garmin USB
> devices) are effectively unsupported in version 3.16.
>
> Fix by renaming back to NON_NMEA_ENABLE.
I saw this in the modweration queue, and have already merge a better fix that
completes the rename.
Sigh. The one case I still can't live-test, I screwed up.
Gary, do you think USB Garmins are out there at enough volume that we
should snap-release to get this fix out?
--
<a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>