Re: [gpsd-dev] [PATCH v2 0/4] Add support for Spectratime iSync devices

[Michael Brown]

On 09/02/16 21:48, Eric S. Raymond wrote:
> > Thanks!  I've updated the patch to:
> >
> > - include regression sample data for "scons check"
> > - increase gpsfake initial delay time (to avoid breaking "scons check")
> > - move the oscillator_t inside the union in gps_data_t
> > - document the changes made to code outside of the iSync driver
>
> These look like good work.  I have merged them.

Thank you!

> However, something went wrong with the way patch 4 was generated and I
> had to do some of the merging by hand.  Please verify that these changes
> look right and operate correctly for you.  Also, compare the isync-log
> and isync-log.chk files to yours - I had to regenerate the .chk file
> due to a botched patch.

Sorry about that.  "git send-email" did complain about a line longer 
than the SMTP-permitted maximum of 998 characters (in the regression 
test data); this may have been the source of the problem.

I have verified that the patches as merged are correct:

  # Rebase my branch onto immediately preceding commit:
  git checkout isync
  git checkout -b temp
  git rebase d019151

  # View differences against final commit as merged
  git diff -b ce10b16

The only non-whitespace difference I see is your added comment in gpsfake.

> Is there any reason the stash buffer feature sould not always be enabled.

It shouldn't cause any functional problems, but it does add another 516 
bytes to gps_lexer_t (if that matters).

Michael