gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] [PATCH 3/4] Eliminate a temporary variable.


From: Beat Bolli
Subject: [gpsd-dev] [PATCH 3/4] Eliminate a temporary variable.
Date: Sat, 20 Feb 2016 13:21:05 +0100

Iterating over a generator function is preferred and saves memory.

Signed-off-by: Beat Bolli <address@hidden>
---
 devtools/identify_failing_build_options.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/devtools/identify_failing_build_options.py 
b/devtools/identify_failing_build_options.py
index 1e8f87a..e9e03ee 100755
--- a/devtools/identify_failing_build_options.py
+++ b/devtools/identify_failing_build_options.py
@@ -88,10 +88,9 @@ def main(starting_number_of_options=0):
     static_params += [key + '=off' for key in always_off]
 
     for i in range(starting_number_of_options, len(knobs)):
-        jj = itertools.combinations(knobs, i)
         print 'Testing at length {}'.format(i)
 
-        for row in list(jj):
+        for row in itertools.combinations(knobs, i):
             print row
             params = static_params + [key + '=on' for key in row]
 
-- 
2.7.1.370.gb2aa7f8



reply via email to

[Prev in Thread] Current Thread [Next in Thread]