gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Make the test_libgps program more useful by allow


From: Jon Schlueter
Subject: Re: [gpsd-dev] [PATCH] Make the test_libgps program more useful by allowing to specify the server and port.
Date: Sun, 21 Feb 2016 19:48:50 -0500

patch seems clean enough, what is the use case for expanding an automation tool? 

Just curious and would like to know thoughts behind the improvements.

Does it allow you to better test/debug code or parsing of input? or something else?

Jon

On Sun, Feb 21, 2016 at 6:28 PM, Robert Norris <address@hidden> wrote:

---------------------------------------
> To: address@hidden
> From: address@hidden
> Date: Sun, 21 Feb 2016 22:14:49 +0100
> Subject: Re: [gpsd-dev] [PATCH] Make the test_libgps program more useful by allowing to specify the server and port.
>
> On 21.02.16 20:05, Robert Norris wrote:
>> + case 'f':
>> + forwardmode = true;
>> + fmsg = strdup(optarg);
>> + break;
>
> Should fmsg not be freed at the end?
>
> Beat
>
> --

It should be freed. Good spot.

Patch now with free() included for free!

                                         


reply via email to

[Prev in Thread] Current Thread [Next in Thread]