[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] commit removing libgpsd.pc.in (1eab3025) - CentOS 6.7 and
From: |
John Hein |
Subject: |
Re: [gpsd-dev] commit removing libgpsd.pc.in (1eab3025) - CentOS 6.7 and Fedora 23 clean builds break |
Date: |
Tue, 23 Feb 2016 22:09:58 -0700 |
Eric S. Raymond wrote at 19:10 -0500 on Feb 23, 2016:
> Jason Azze <address@hidden>:
> > A recent commit seems to have broken my automated builds on CentOS 6.7 i686
> > and Fedora 23 x86_64.
.
.
>
> Thanks for the heads-up. Turns out John Hein's patch was a bit incomplete.
> He probably failed to catch this for the same reason I did - libgpsd.pc
> sitting in the directory from a previous build.
>
> Fix is pushed.
Yes, the submitted patch was incomplete. It was missing a patch to
SConstruct part of which you found - Thanks. I had inadvertently
mixed it in with the first version of my LIBPATH patch.
In any case, there's still one more that should be committed:
--- SConstruct
+++ SConstruct
@@ -1357,7 +1357,7 @@ if manbuilder:
build = env.Alias('build',
[libraries, binaries, python_targets,
"gpsd.php", manpage_targets,
- "libgps.pc", "libgpsd.pc", "gpsd.rules"])
+ "libgps.pc", "gpsd.rules"])
env.Default(*build)
if qt_env: