gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] [PATCH] Fixes install breakage from commit 79800e8.


From: Fred Wright
Subject: [gpsd-dev] [PATCH] Fixes install breakage from commit 79800e8.
Date: Sun, 6 Mar 2016 17:19:21 -0800

If the list of .pc files had been a list rather than a tuple, the
change would have worked.  But since it was a tuple, reducing it to
one item without including the comma as a "tuple flag" turned the
parens into simple parens, causing the "for" to iterate over the
characters of the single string instead of the strings.

Removing the now-superfluous tuple and iteration fixes it.

TESTED:
Verified that the previously failing install on Ubuntu works with this
fix.
---
 SConstruct | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/SConstruct b/SConstruct
index edad986..62953b3 100644
--- a/SConstruct
+++ b/SConstruct
@@ -1414,7 +1414,7 @@ else:
                         python_progs_install,
                         python_egg_info_install]
 
-pc_install = [env.Install(installdir('pkgconfig'), x) for x in ("libgps.pc")]
+pc_install = [env.Install(installdir('pkgconfig'), 'libgps.pc')]
 if qt_env:
     pc_install.append(qt_env.Install(installdir('pkgconfig'), 'Qgpsmm.pc'))
     pc_install.append(qt_env.Install(installdir('libdir'), 'libQgpsmm.prl'))
-- 
2.7.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]