[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH] ntpshmread.c is only used by ntpshmmon
|
From: |
Robert Norris |
|
Subject: |
Re: [gpsd-dev] [PATCH] ntpshmread.c is only used by ntpshmmon |
|
Date: |
Fri, 11 Mar 2016 00:10:31 +0000 |
----------------------------------------
> Date: Thu, 10 Mar 2016 18:16:23 -0500
> From: address@hidden
> To: address@hidden
> CC: address@hidden
> Subject: Re: [gpsd-dev] [PATCH] ntpshmread.c is only used by ntpshmmon
>
> Leave it in the library, please. That's where it belongs architrecturally;
> you don't know that future clients won't want it.
> --
Nothing is exposed via the C API interface of gps.h that could use it, so in
IMHO it doesn't belong in libgps
Secondly currently building with NTPSHM off, it still includes at least
sys/ipc.h (in ntpshm.h) so it prevents building libgps on Windows;
otherwise inclusion of gpsd_config.h and more #ifdefs would be required
Thus moving it to only where it is used seemed the simplest solution.
Alternatively one could move ntpshmread.c into libgpsd instead, in case some
future other new gpsd *internal* client might want it.
Rob.