gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] oncore PPS fix


From: Håkan Johansson
Subject: [gpsd-dev] oncore PPS fix
Date: Sat, 12 Mar 2016 19:26:11 +0100
User-agent: Alpine 2.11 (DEB 23 2013-08-11)


0001 patch fixes debug output formatting segfault; long long is %lld (likely undetected due to long long being int size on x86_64).

perhaps this could have been found by using the PRINTF_FUNC in the prototype for ppsthread_log. aha, is none, is a function pointer: log_hook. could it be applied there? or use a wrapper call if one wants the compiler to find this

0002 patch fixes edge detection. (found by an oncore apparently triggering on the wrong edge, which casued offset and also large standard deviation. its trailing PPS edge does not have good timing properties)

0003 patch is just a random spell fix.

Cheers,
Håkan

Attachment: 0001-cycle-and-duration-became-long-long-in-ebb1d9da-use-.patch
Description: Text Data

Attachment: 0002-state_last_tio-was-never-set-so-edge-detection-not-w.patch
Description: Text Data

Attachment: 0003-Minor-spell-and-wording.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]