Re: [gpsd-dev] oncore PPS fix

[Eric S. Raymond]

Håkan Johansson <address@hidden>:
> 
> 0001 patch fixes debug output formatting segfault; long long is %lld (likely
> undetected due to long long being int size on x86_64).
>
> perhaps this could have been found by using the PRINTF_FUNC in the prototype
> for ppsthread_log.  aha, is none, is a function pointer: log_hook.  could it
> be applied there?  or use a wrapper call if one wants the compiler to find
> this

Too complicated.  I've applied this as is.

> 0002 patch fixes edge detection.  (found by an oncore apparently triggering
> on the wrong edge, which casued offset and also large standard deviation.
> its trailing PPS edge does not have good timing properties)

I'm reluctant to apply this without review from Gary Miller, who owns that
code.  Gary, is this a good patch?

> 0003 patch is just a random spell fix.

Applied.
-- 
                <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>