Re: [gpsd-dev] [PATCH] Using GOODTIME_IS for UBX_MODE_TMONLY.

[Håkan Johansson]

The scary part is perhaps my misguided splitting of patches, forgetting to 
mention the dependency:  This (ubx) patch was on top of an yet not 
applied one introducing the GOODTIME_IS flag (mail of Mar 14).

I attach the diff file here as well.

Sorry for the mess,
Håkan


On Sun, 20 Mar 2016, Eric S. Raymond wrote:

> Gary E. Miller <address@hidden>:
> > Håkan Johansson <address@hidden> wrote:
> >
> > > Note: I have no ubx device; so no live testing.
> >
> > I'd be scared to apply this patch until someone has live tested it.
>
> I'm not scared.  It actually fixes a bug - if somehow the UBX is in time-only
> mode you don't want it asserting that it can ship a 3D fix, which is what
> the code does without this patch.
>
> That's an edge case we may never see.  I believe timing mode is disabled
> on most of the u-blox variants - you have to buy the extra-cost "T" marque
> to get it.
>
> I looked into this possibility at one point and it turned out to be
> uninteresting; the non-T variants already deliver more precision that
> WAN time service can use, practically speaking, so the T variants would be
> overengineering.  They might be a good fit for PTP over a LAN.
> --
>                 <a href="http://www.catb.org/~esr/";>Eric S. Raymond</a>

0004-Introduce-the-flag-GOODTIME_IS-to-mark-that-the-devi.patch
Description: Text Data