Re: [gpsd-dev] [PATCH] Add Windows versions of time related functions.

[Gary E. Miller]

Yo Beat!

On Wed, 23 Mar 2016 23:53:01 +0100
Beat Bolli <address@hidden> wrote:

> >>> Merged.
> >>>     
> >> Are we now ok with malloc()?  
> > 
> > I just did a pull of git HEAD, the searched for malloc.  I see mo
> > malloc() added i the last year.
> > 
> > What am I missing?  
> 
> The patch that started this thread uses strdup() which calls malloc().


Yeah, there it is.  Good eye.

Since the input (isotime) is a fixed length string it would be
easy to get rid of the malloc().  Or, even better, there was never any
reason to duplicate the input string at all.  Patches anyone?

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

pgpLtZ7bjQPRe.pgp
Description: OpenPGP digital signature