[gpsd-dev] [PATCH 06/12] Fixes Gtk warnings related to xgps/xgpsspeed error boxes.

[Fred Wright]

The Gtk MessageDialog function gives a warning if no parent window is
specified.  Since the main window already exists in those cases, it's
simply a matter of passing the extra argument to MessageDialog.

This has the side effect of changing the position of the dialog box,
such that it's centered over the parent window rather than being near
its upper left-hand corner.  In the xgps case, it appears to be
centered over whichever subwindow was most recently updated.

TESTED:
Verified that both the gpsd not running and gpsd stopped running cases
no longer produce warning messages on the terminal.
---
 xgps      | 6 ++++--
 xgpsspeed | 2 ++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/xgps b/xgps
index 79fd3fb..62cdb3a 100755
--- a/xgps
+++ b/xgps
@@ -850,7 +850,8 @@ class Base:
 
     def handle_hangup(self, _source, _condition):
         "Handle hangup condition from the daemon."
-        w = Gtk.MessageDialog(type=Gtk.MessageType.ERROR,
+        w = Gtk.MessageDialog(parent=self.window,
+                              type=Gtk.MessageType.ERROR,
                               flags=Gtk.DialogFlags.DESTROY_WITH_PARENT,
                               buttons=Gtk.ButtonsType.CANCEL)
         w.connect("destroy", lambda _unused: Gtk.main_quit())
@@ -908,7 +909,8 @@ if __name__ == "__main__":
             base.watch(daemon, device)
             base.main()
         except socket.error:
-            w = Gtk.MessageDialog(type=Gtk.MessageType.ERROR,
+            w = Gtk.MessageDialog(parent=base.window,
+                                  type=Gtk.MessageType.ERROR,
                                   flags=Gtk.DialogFlags.DESTROY_WITH_PARENT,
                                   buttons=Gtk.ButtonsType.CANCEL)
             w.set_markup("gpsd is not running.")
diff --git a/xgpsspeed b/xgpsspeed
index 1a47b3e..b0dda09 100755
--- a/xgpsspeed
+++ b/xgpsspeed
@@ -608,6 +608,7 @@ class Main(object):
 
     def handle_hangup(self, _dummy, _unused):
         w = Gtk.MessageDialog(
+            parent=self.window,
             type=Gtk.MessageType.ERROR,
             flags=Gtk.DialogFlags.DESTROY_WITH_PARENT,
             buttons=Gtk.ButtonsType.OK
@@ -653,6 +654,7 @@ class Main(object):
             Gtk.main()
         except SocketError:
             w = Gtk.MessageDialog(
+                parent=self.window,
                 type=Gtk.MessageType.ERROR,
                 flags=Gtk.DialogFlags.DESTROY_WITH_PARENT,
                 buttons=Gtk.ButtonsType.OK
-- 
2.8.0