[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH 5/8] NITEMS definition cleanup.
|
From: |
Gary E. Miller |
|
Subject: |
Re: [gpsd-dev] [PATCH 5/8] NITEMS definition cleanup. |
|
Date: |
Wed, 20 Apr 2016 13:07:20 -0700 |
Yo Robert!
On Wed, 20 Apr 2016 01:25:05 +0100
Robert Norris <address@hidden> wrote:
> In moving to a more rigorous split between libgpsd and libgps, there
> currently exists NITEMS definitions in both sections - so it gpsd
> itself defining more than once.
Moving to one definition is a good thing.
> Here instead of creating a single definition, I moved one to be
> visible somewhere to provide for the libgps side.
So, half right.
> However libgps.h gets used with libgpsd so one would get compiler
> redefinition warnings.
How about solving it the right way? A single header file in common
with both sides, things things ony get defined once.
> Perhaps creating a single version (e.g. in the new gpsd_definitons.h
> file or similar) would be better.
Yup.
As a rule, when you define something twice, they will eventually get out
of sync.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1 541 382 8588
pgpmMROuHOU_I.pgp
Description: OpenPGP digital signature