gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 2/8] Shift hex functions definitions into its own


From: Robert Norris
Subject: Re: [gpsd-dev] [PATCH 2/8] Shift hex functions definitions into its own header file.
Date: Thu, 21 Apr 2016 23:18:41 +0100


? With this patch applied ?

I got this:

gcc -o driver_skytraq.o -c -O0 -g -Wextra -Wall -Wno-uninitialized 
-Wno-missing-field-initializers -Wcast-align -Wmissing-declarations 
-Wmissing-prototypes -Wstrict-prototypes -Wpointer-arith -Wreturn-type -pthread 
-Wmissing-declarations -O2 -pthread -I/usr/include/dbus-1.0 
-I/usr/lib/x86_64-linux-gnu/dbus-1.0/include driver_skytraq.c

driver_skytraq.c: In function 'sky_msg_E2':
driver_skytraq.c:397:4: warning: implicit declaration of function 
'gpsd_hexdump' [-Wimplicit-function-declaration]
    gpsd_hexdump(session->msgbuf, sizeof(session->msgbuf),
    ^
driver_skytraq.c:393:4: warning: format '%s' expects argument of type 'char *', 
but argument 7 has type 'int' [-Wformat=]
    "Skytraq: Beidou D1 subframe PRN %d Subframe %d "
    ^
driver_skytraq.c: In function 'sky_msg_E3':
driver_skytraq.c:434:4: warning: format '%s' expects argument of type 'char *', 
but argument 7 has type 'int' [-Wformat=]
    "Skytraq: Beidou D2 subframe PRN %d Subframe %d "


>gcc --version
gcc (Debian 5.3.1-14) 5.3.1 20160409

--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.


----------------------------------------
> Date: Thu, 21 Apr 2016 14:50:11 -0700
> From: address@hidden
> To: address@hidden
> CC: address@hidden
> Subject: Re: [gpsd-dev] [PATCH 2/8] Shift hex functions definitions into its 
> own header file.
>
> Yo Robert!
>
> On Thu, 21 Apr 2016 22:41:09 +0100
> Robert Norris <address@hidden> wrote:
>
>> Note due to last weeks commit "Start to decode Beidou subframe data."
>> driver_skytraq.c now uses gpsd_hexdump()
>
> Yup.
>
>> So this patch needs to update driver_skytraq.c to include hex.h as
>> well.
>
> No. It compiles just fine for me:
>
> leapseconds_cache_rebuild(["leapseconds.cache"], ["leapsecond.py"])
> timebase_h(["timebase.h"], ["leapseconds.cache"])
> gcc -o driver_skytraq.o -c -Wmissing-prototypes -Wextra -Wall 
> -Wno-uninitialized -Wno-missing-field-initializers -Wcast-align 
> -Wmissing-declarations -Wstrict-prototypes -Wpointer-arith -Wreturn-type 
> -pthread -Wmissing-declarations -O2 -pthread -DHAVE_SYS_TIMEPPS_H=1 
> -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include 
> -I/usr/include/libusb-1.0 driver_skytraq.c
> scons: `install' is up to date.
>
> No errors, no warnings.
>
>> I'll update this soon.
>
> No need.
>
>
> RGDS
> GARY
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
> address@hidden Tel:+1 541 382 8588
                                          


reply via email to

[Prev in Thread] Current Thread [Next in Thread]