gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] gps.py: Don't negate flags twice!


From: Gary E. Miller
Subject: Re: [gpsd-dev] [PATCH] gps.py: Don't negate flags twice!
Date: Mon, 13 Jun 2016 11:55:23 -0700

Yo Nuno!

How would someone test this?

On Mon, 13 Jun 2016 19:32:23 +0100
Nuno Gonçalves <address@hidden> wrote:

> Flags are already interpreted as false at class gpsjson when
> WATCH_DISABLE is present.
> 
> Signed-off-by: Nuno Goncalves <address@hidden>
> ---
>  gps/gps.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gps/gps.py b/gps/gps.py
> index 46daa9d..d80fac9 100755
> --- a/gps/gps.py
> +++ b/gps/gps.py
> @@ -280,7 +280,7 @@ class gps(gpscommon, gpsdata, gpsjson):
>                      arg += 'r-'
>                      return self.send(arg)
>              else:
> -                gpsjson.stream(self, ~flags, devpath)
> +                gpsjson.stream(self, flags, devpath)
>          else:  # flags & WATCH_ENABLE:
>              if flags & WATCH_OLDSTYLE:
>                  arg = 'w+'




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

Attachment: pgp7FiFn1CQOo.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]