[gpsd-dev] [PATCH 1/3] TSIP: improve comments

[Nuno Gonçalves]

Signed-off-by: Nuno Goncalves <address@hidden>
---
 driver_tsip.c | 3 ++-
 packet.c      | 9 ++++++---
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/driver_tsip.c b/driver_tsip.c
index 6fa79b6..3ded926 100644
--- a/driver_tsip.c
+++ b/driver_tsip.c
@@ -2,6 +2,7 @@
  * Handle the Trimble TSIP packet format
  * by Rob Janssen, PE1CHL.
  * Accutime Gold support by Igor Socec <address@hidden>
+ * Trimble RES multi-constelation support by Nuno Goncalves <address@hidden>
  *
  * Week counters are not limited to 10 bits. It's unknown what
  * the firmware is doing to disambiguate them, if anything; it might just
@@ -947,7 +948,7 @@ static gps_mask_t tsip_parse_input(struct
gps_device_t *session)
  session->driver.tsip.last_48 = now;
     }

-    if ((now - session->driver.tsip.last_5c) >= 5) {
+    if ((now - session->driver.tsip.last_5c) >= 5) {  /* 5d in
multi-gnss devices */
  /* Request Current Satellite Tracking Status */
  putbyte(buf, 0, 0x00); /* All satellites */
  (void)tsip_write(session, 0x3c, buf, 1);
diff --git a/packet.c b/packet.c
index 6e3125f..4ab0b5e 100644
--- a/packet.c
+++ b/packet.c
@@ -1881,8 +1881,8 @@ void packet_parse(struct gps_lexer_t *lexer)
 #ifdef TSIP_ENABLE
  /* check for some common TSIP packet types:
  * 0x13, TSIP Parsing Error Notification
- * 0x38, Request SV system data
  * 0x1c, Hardware/Software Version Information
+ * 0x38, Request SV system data
  * 0x41, GPS time, data length 10
  * 0x42, Single Precision Fix, data length 16
  * 0x43, Velocity Fix, data length 20
@@ -1893,17 +1893,20 @@ void packet_parse(struct gps_lexer_t *lexer)
  * 0x4a, LLA Position, data length 20
  * 0x4b, Machine Code Status, data length 3
  * 0x4c, Operating Parameters Report, data length 17
- * 0x54, One Satellite Bias, data length 4
+ * 0x54, One Satellite Bias, data length 4 - not according to the
length check below!
+ * 0x55, I/O Options, data length 4
  * 0x56, Velocity Fix (ENU), data length 20
  * 0x57, Last Computed Fix Report, data length 8
  * 0x5a, Raw Measurements
  * 0x5b, Satellite Ephemeris Status, data length 16
  * 0x5c, Satellite Tracking Status, data length 24
  * 0x5e, Additional Fix Status Report
- * 0x6d, All-In-View Satellite Selection, data length 16+numSV
+ * 0x5f, 0x5F-01-0B: Reset Error Codes, data length 25 - not
according to the length check below!
+ * 0x6d, All-In-View Satellite Selection, data length 17+numSV
  * 0x82, Differential Position Fix Mode, data length 1
  * 0x83, Double Precision XYZ, data length 36
  * 0x84, Double Precision LLA, data length 36
+ * 0x8f, Superpackets
  * 0xbb, GPS Navigation Configuration
  * 0xbc, Receiver Port Configuration
  *
-- 
2.7.4

0001-TSIP-improve-comments.patch
Description: Text Data