gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH 1/3] TSIP: improve comments


From: Oliver Jowett
Subject: Re: [gpsd-dev] [PATCH 1/3] TSIP: improve comments
Date: Tue, 21 Jun 2016 08:02:06 -0500

On 20 June 2016 at 20:06, Gary E. Miller <address@hidden> wrote:
Yo Nuno!

I also lookad at the git diff a bit.  Tis looks like it is going backwards:

-    /* FIX-ME: is a constant offset right here? */
-    return 0.075;
+    /* the offset depends on the generation and is not reliable, some example measurements:
+     * Trimble Resolution T   : 0.03s to 0.200s (depends on the SV# being tracked)
+     * Trimble Resolution SMTx: 0.300 to 0.500s (unpredictable)
+     * Trimble RES SMT 360    : 0.028s (this appears very stable)*/
+    return 0.0;

Your comments point to a code improvement, but then go backwards.  By
your comments seems that 0.075 is more correct than 0.0 How about a real
fix, or at least a partial fix?  Just remopving it will degrade existing
users.

On the contrary, the existing offset is just wrong and actively interferes if you're using a SMT 360, you end up with a negative fudge which is extremely counterintuitive.
I only worked out what was going on when I trawled through the code and found this bogus offset (it's patched out in my local copy).
So speaking as an existing user, this patch is an improvement.

Oliver


reply via email to

[Prev in Thread] Current Thread [Next in Thread]