[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections.
From: |
Gary E. Miller |
Subject: |
Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections. |
Date: |
Fri, 15 Jul 2016 14:09:34 -0700 |
Yo Fred!
On Fri, 15 Jul 2016 13:47:28 -0700 (PDT)
Fred Wright <address@hidden> wrote:
> > > Please consider using "git am" to apply emailed patches generated
> > > with "git format-patch" (all of mine, at least). This takes the
> > > commit message directly from the email, which is both less work
> > > and less error-prone than creating a new commit message from
> > > scratch. One can still add an SOB line with "-s" if desired.
> > > This is the way Eric does it.
> >
> > Gack. Email mungs patchs. Which is why I had to manually apply.
> > I like format-patch, but to really work it needs to be sent as an
> > attachment. Send you patchs as attachments and maybe I'll apply
> > them as-is.
>
> It must be your email client that's doing the munging.
At a minimum we know the gpsd-dev mail server is munging the
subject. The subject gets sucked into the git commit comment.
> An even cleaner approach is to fetch directly from my GitHub repo
> (which doesn't require having a GitHub account). Patches via email
> are just sooo twentieth-century. :-) But so far the only one who's
> taken patches that way is Jon.
I guess I better learn how..
> git fetch https://github.com/fhgwright/gpsd +doc-fixes:fwpatch
I did that:
pi2 gpsd # git fetch https://github.com/fhgwright/gpsd +doc-fixes:fwpatch
remote: Counting objects: 4, done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 4 (delta 1), reused 1 (delta 1), pack-reused 0
Unpacking objects: 100% (4/4), done.
From https://github.com/fhgwright/gpsd
* [new branch] doc-fixes -> fwpatch
pi2 gpsd # git diff
But nothing in the diff, nothing in git status, and nothing in git log.
What did I do wrong?
> That will give you a new branch "fwpatch" derived from my doc-fixes
> branch (where the missing patch lives). Then you can diff and/or
> merge as usual.
Well, maybe usual for you, I'm a bit lost...
> If that doesn't work, I'll send an attachment, though the
> non-attachment approach seems to be better for most people
> (particularly when the sending email client insists on encoding the
> attachment in a way that isn't directly viewable in some clients).
The value to sending to the list is that more eyes get to see the patch.
This is a lot more work for the casual lurker, and I don't have it
working yet.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1 541 382 8588
pgpZxpsZ3l5zJ.pgp
Description: OpenPGP digital signature
- [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Fred Wright, 2016/07/10
- [gpsd-dev] [PATCH 2/2] Fixes typo in logfile comment., Fred Wright, 2016/07/10
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Gary E. Miller, 2016/07/14
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Fred Wright, 2016/07/15
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Fred Wright, 2016/07/15
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections.,
Gary E. Miller <=
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Fred Wright, 2016/07/15
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Gary E. Miller, 2016/07/15
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Fred Wright, 2016/07/15
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Hal Murray, 2016/07/15
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Frank Nicholas, 2016/07/16
- Re: [gpsd-dev] [PATCH 1/2] More 13-bit week number corrections., Fred Wright, 2016/07/17