Re: [gpsd-dev] [PATCH 3/3] TSIP: support multi-constelation chip packets

[Nuno Gonçalves]

I don't have one of this chips anymore but I'll send it as soon as I
get one...this will probably take a few months.

Thanks,
Nuno

On Tue, Jul 19, 2016 at 2:58 AM, Gary E. Miller <address@hidden> wrote:
> Yo Nuno!
>
> On Mon, 20 Jun 2016 16:06:02 +0100
> Nuno Gonçalves <address@hidden> wrote:
>
>>  driver_tsip.c | 116
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>> packet.c      |  32 ++++++++++++---- 2 files changed, 139
>> insertions(+), 9 deletions(-)
>
>
> I came up with a way for changing TSIP_CHANNELS to not break GPGSA.
>
> Along the way I found a few other things wrong with GPGSA, and there
> will need to be more changes when we actually see GPS using more then
> 12 sats.
>
> So I cleaned up your patch, mostly line length and comment problems,
> commited and pushed it.
>
> What this still needs is a good regression test for these changes.
> Without regression tests there is no way to know if something gets changed
> that break the output of your patch.
>
> Could you please send a few minutes of TSIP output that has the
> 0x5d and 0x6c sentences?  Then I can add to the regression tests.
>
> RGDS
> GARY
> ---------------------------------------------------------------------------
> Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
>         address@hidden  Tel:+1 541 382 8588