gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] Warnings on 32 bit Fedora 24


From: Hal Murray
Subject: [gpsd-dev] Warnings on 32 bit Fedora 24
Date: Fri, 22 Jul 2016 02:18:07 -0700

gcc -o bits.o -c -Wmissing-prototypes -Wextra -Wall -Wno-uninitialized 
-Wno-missing-field-initializers -Wcast-align -Wmissing-declarations 
-Wstrict-prototypes -Wpointer-arith -Wreturn-type -pthread 
-Wmissing-declarations -O2 -pthread -DHAVE_SYS_TIMEPPS_H=1 bits.c
bits.c: In function 'ubits':
bits.c:40:19: warning: left shift of negative value [-Wshift-negative-value]
     fld &= ~(-1LL << width);
                   ^~
bits.c: In function 'sbits':
bits.c:71:15: warning: left shift of negative value [-Wshift-negative-value]
  fld |= (-1LL << (width - 1));
               ^~



I'm not seeing this one now, but the source hasn't changed.
Looks like the if/else needs to be indented.
Maybe a tab/space mixup.

Ah...  It comes from scons install when run as root.

gcc -o gpsd_json.o -c -Wmissing-prototypes -Wextra -Wall -Wno-uninitialized 
-Wno-missing-field-initializers -Wcast-align -Wmissing-declarations 
-Wstrict-prototypes -Wpointer-arith -Wreturn-type -pthread 
-Wmissing-declarations -O2 -pthread -DHAVE_SYS_TIMEPPS_H=1 gpsd_json.c
gpsd_json.c: In function 'json_aivdm_dump':
gpsd_json.c:1996:13: warning: this 'else' clause does not guard... 
[-Wmisleading-indentation]
             else
             ^~~~
gpsd_json.c:2004:3: note: ...this statement, but the latter is misleadingly 
indented as if it is guarded by the 'else'
   break;
   ^~~~~


-- 
These are my opinions.  I hate spam.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]