[gpsd-dev] Lots of warnings

[Hal Murray]

I thought gpsd was pretty clean, but I guess nobody has been looking 
carefully.

Here is my collection from various systems...  If it matters, I'll dig out 
the version of gcc and the distro.

bits.c:40:19: warning: left shift of negative value [-Wshift-negative-value]
bits.c:71:15: warning: left shift of negative value [-Wshift-negative-value]
bits.c:40:19: warning: left shift of negative value [-Wshift-negative-value]
bits.c:71:15: warning: left shift of negative value [-Wshift-negative-value]
ppscheck.c:58:1: warning: 'static' is not at beginning of declaration 
[-Wold-style-declaration]
ppscheck.c:65:6: warning: no previous prototype for 'usage' 
[-Wmissing-prototypes]
ppscheck.c:118:6: warning: format '%10ld' expects type 'long int', but 
argument 3 has type 'time_t'
ppscheck.c:129:1: warning: control reaches end of non-void function 
[-Wreturn-type]
gps2udp.c:302:18: warning: array subscript is above array bounds
ntpshmmon.c:34:5: warning: implicit declaration of function 'memset'
ntpshmmon.c:34:5: warning: incompatible implicit declaration of built-in 
function 'memset'
timespec_str.c:48:12: warning: absolute value function 'labs' given an 
argument of type 'const time_t' (aka 'const long long') but has parameter of 
type 'long' which may cause truncation of value [-Wabsolute-value]
driver_nmea0183.c:1255:10: warning: taking the absolute value of unsigned 
type 'unsigned int' has no effect [-Wabsolute-value]

gpsd_json.c:1996:13: warning: this 'else' clause does not guard... 
[-Wmisleading
-indentation]

cc1plus: warning: command line option "-Wmissing-declarations" is valid for 
C/ObjC but not for C++

A blizzard from FreeBSD 9.3-RELEASE-p33 i386

ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr.ar
ra
y')
ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr')
ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr.ar
ra
y.arr.objects')
ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr.ar
ra
y.arr')
ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr.ar
ra
y')

libgps_json.c:146: warning: initialized field overwritten
libgps_json.c:146: warning: (near initialization for 
'json_attrs_2[11].addr.arra
y')
libgps_json.c:146: warning: initialized field overwritten
libgps_json.c:146: warning: (near initialization for 'json_attrs_2[11].addr')
libgps_json.c:146: warning: initialized field overwritten
libgps_json.c:146: warning: (near initialization for 
'json_attrs_2[11].addr.arra
y.arr.objects')
libgps_json.c:146: warning: initialized field overwritten

rtcm2_json.c:62: warning: initialized field overwritten
rtcm2_json.c:62: warning: (near initialization for 'json_rtcm1[8].addr.array')
rtcm2_json.c:62: warning: initialized field overwritten
rtcm2_json.c:62: warning: (near initialization for 'json_rtcm1[8].addr')
rtcm2_json.c:62: warning: initialized field overwritten
rtcm2_json.c:62: warning: (near initialization for 
'json_rtcm1[8].addr.array.arr
.objects')
rtcm2_json.c:62: warning: initialized field overwritten

ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr.ar
ra
y')
ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr')
ais_json.i:324: warning: initialized field overwritten
ais_json.i:324: warning: (near initialization for 'json_ais6_fid25[13].addr.ar
ra
y.arr.objects')
ais_json.i:324: warning: initialized field overwritten

libgps_json.c:146: warning: initialized field overwritten
libgps_json.c:146: warning: (near initialization for 
'json_attrs_2[11].addr.arra
y')
libgps_json.c:146: warning: initialized field overwritten
libgps_json.c:146: warning: (near initialization for 'json_attrs_2[11].addr')
libgps_json.c:146: warning: initialized field overwritten
libgps_json.c:146: warning: (near initialization for 
'json_attrs_2[11].addr.arra
y.arr.objects')
libgps_json.c:146: warning: initialized field overwritten

and a ffew more



-- 
These are my opinions.  I hate spam.