Re: [gpsd-dev] [PATCH 1/2] Moves Linux-only ppscheck program back to contrib/.

[Robert Norris]

Ah, the joy of scons!

AFAIK scons cleans/builds all the programs it knows about.

However in the gpsd SConstruct there are code paths for 'cleaning' and 'building', so both paths must generate the same list of programs so they can be built or cleaned.

I think the kpps and pps tests need to be available in both 'cleaning' and normal building paths.

ATM the pps test is only in the 'build' path, so it doesn't know about it to clean it.

Thus I believe the pps (and so also the kpps) tests need to be before the "if cleaning or helping:" line 617, but after the variable config is made available.

HTH.

--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.

---

From: gpsd-dev <gpsd-dev-bounces+address@hidden> on behalf of Hal Murray <address@hidden>
Sent: 10 August 2016 07:26:30
To: Gary E. Miller
Cc: GPSD Developers List
Subject: Re: [gpsd-dev] [PATCH 1/2] Moves Linux-only ppscheck program back to contrib/.

 

address@hidden said:
>> scons --clean doesn't get rid of ppscheck or ppscheck.o
> I just looked at it.  I have no idea how scons decides what to clean, or why
> it does not 'just work'.

> Is this on a TIOMCIWAIT system where ppscheck works fine?  Or is this on a
> non-TIOMCIWAIT where ppcheck got built but should not have been built?

It gets left on a system with TIOMCIWAIT.

--
These are my opinions.  I hate spam.