gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] Today's warnings....


From: Gary E. Miller
Subject: Re: [gpsd-dev] Today's warnings....
Date: Fri, 12 Aug 2016 16:18:09 -0700

Yo Hal!

On Fri, 12 Aug 2016 16:08:51 -0700
Hal Murray <address@hidden> wrote:

> address@hidden said:
> >> timespec_str.c:48:12: warning: absolute value function 'labs'
> >> given  
> > You are not on git head.  That was fixed.   
> 
> I think you fixed something similar but missed this one.  The problem
> is that time_t is long long on FreeBSD but labs takes a long.  Patch
> after I test it.

I did that already, note the llabs(), not labs():

commit 290701e02dc3dbc2dc6e4ce5dce2a318d322459c
Author: Gary E. Miller <address@hidden>
Date:   Wed Aug 10 12:40:43 2016 -0700

    (void) snprintf( buf, buf_size, "%c%lld.%09ld",
                          sign,
                          (long long)llabs(ts->tv_sec),
                          (long)labs(ts->tv_nsec));

So your git head is 2 days old.

> New one...

Same one, new to you.

> NetBSD can't find llabs.  ????
> 
> timespec_str.c:52:6: warning: implicit declaration of function
> 'llabs' [-Wimplicit-function-declaration]

So, what's the fix?  I don't want to get sucked into patching an OS
I can't test.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

Attachment: pgpRJJR9AzScI.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]