gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gpsd-dev] [PATCH] Fix memory leak in Qt build.


From: Robert Norris
Subject: [gpsd-dev] [PATCH] Fix memory leak in Qt build.
Date: Thu, 2 Feb 2017 23:39:03 +0000

Since privdata is always allocated in gps_sock_open(),
it always needs to be free'd in gps_sock_close().
---
 libgps_sock.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/libgps_sock.c b/libgps_sock.c
index 57da2f30..ea04b8cd 100644
--- a/libgps_sock.c
+++ b/libgps_sock.c
@@ -115,11 +115,10 @@ bool gps_sock_waiting(const struct gps_data_t *gpsdata, 
int timeout)
 int gps_sock_close(struct gps_data_t *gpsdata)
 /* close a gpsd connection */
 {
-#ifndef USE_QT
-    int status;
-
     free(PRIVATE(gpsdata));
     gpsdata->privdata = NULL;
+#ifndef USE_QT
+    int status;
     status = close(gpsdata->gps_fd);
     gpsdata->gps_fd = -1;
     return status;
-- 
2.11.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]