Re: [gpsd-dev] [PATCH 4/4] Add Valgrind tests for gps library interface variants.

[Fred Wright]

On Mon, 13 Feb 2017, Robert Norris wrote:

> Since it doesn't get run automatically I didn't test with various scons 
> config options such as qt=no, etc...

Sure, but one doesn't want valgrind-audit to be broken.  In particular,
installing Qt shouldn't be a prerequisite for running it.

Without digging into it, I suspect that adding test_libgps unconditionally
is OK, but the other two need to be conditionsl.

Meanwhile, I need to figure out why valgrind-audit is completely broken
(for running, not building) on OSX, apparently at least as far back as
release-3.16.  I could swear I ran it at some point; maybe something in
the OS changed.

> I'll come up with an improved version.

OK.  Also consider writing more concise commit summaries.  Those are
sometimes displayed in the same line as other information, and line wrap
is annoying.  The official guideline is 50 characters, which is sometimes
too constraining, but it's something to shoot for.  If the concise summary
isn't an adequately complete description (as is usually the case), then
one can add as many additional paragraphs as necessary to properly explain
it.

Fred Wright