Re: [gpsd-dev] Windows version of libgps

[Fred Wright]

On Mon, 20 Feb 2017, Robert Norris wrote:

> The update works for me.

OK, I pushed it to master.  I noticed in the process that I'd forgotten to
rebase it with some other recent changes, but they were in unrelated
areas.

> I've added a syslog() fallback into os_compat.c so changes to other programs 
> are minimal.
> Patches to follow shortly.

OK.

> Now had time to run gpxlogger on Windows and seems to work OK.
>
> So while playing with gpxlogger, I found a few issues - hence the first set 
> of patches.

OK.  I probably won't have time to look at those in detail tonight.  My
personal style preference is to put a space after the "(void)", but I
haven't looked at what normal GPSD style does.

BTW, I did the rework of DaemonInstance that I mentioned, so LibInstance
(or perhaps LibraryInstance) should now be a simple subclass of
SubprogramInstance, only overriding spawn().  Though I forgot to check
whether the generic spawn() is fully adequate.  But valgrind-audit.py will
need some work to make the added stuff appropriately optional.

Valgrind itself seems to be problematic, and only fully usable on Linux.

Fred Wright