Re: [gpsd-dev] [PATCH 1/3] OS syslog compatibility fallback.

[Fred Wright]

On Fri, 24 Feb 2017, Robert Norris wrote:

> Mainly for Windows systems which doesn't have syslog().
[...]

I think it would be cleaner to have the conditional include of syslog.h
just in os_compat.h.  That means that anything using syslog would need to
include os_compat.h, but that's already needed for the fallback prototypes
and definitions, anyway.  Of course, anything not trying to work on
Windows could be left alone.

The set of syslog-related definitions could be pared down some.  Since
five of the eight priority definitions are used, it might as well include
all of them for completeness, but since only two of the openlog flags
(LOG_PID and LOG_PERROR) and only two of the facility codes (LOG_USER and
LOG_DAEMON) are used, it would make sense just to define those.

Fred Wright