gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] [PATCH] Improved Windows build of gpspipe


From: Robert Norris
Subject: Re: [gpsd-dev] [PATCH] Improved Windows build of gpspipe
Date: Sun, 31 Dec 2017 13:58:07 +0000

No the Windows Mingw system doesn't have termio.h

There are already various other ifdefs for HAVE_TERMIOS_H around termios.h 
serial port usage.

This just avoids one more declaration of termios type variables, which as I 
mention - this one used to compile OK, but now doesn't with the latest openSUSE 
Open Build Service gcc (and/or options applied to gcc).

The patch should of had more commentary (its in my local git branch):

"Protection against unused variables and potential unknown
 storage size when termios.h is not available."

Not sure why my patch generation omitted this.

--
Be Seeing You - Rob.
If at first you don't succeed,
then skydiving isn't for you.

________________________________________
From: gpsd-dev <address@hidden> on behalf of Gary E. Miller <address@hidden>
Sent: 24 December 2017 20:49
To: address@hidden
Subject: Re: [gpsd-dev] [PATCH] Improved Windows build of gpspipe

Yo Robert!

Do you now have termios.h?  Is this all you need to build w/o termios.h?

On Sun, 24 Dec 2017 12:20:51 +0000
Robert Norris <address@hidden> wrote:

> ---
>  gpspipe.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/gpspipe.c b/gpspipe.c
> index 72eed30..884fc59 100644
> --- a/gpspipe.c
> +++ b/gpspipe.c
> @@ -67,7 +67,9 @@ static void spinner(unsigned int, unsigned int);
>  #define BAUDRATE B4800
>
>  /* Serial port variables */
> +#ifdef HAVE_TERMIOS_H
>  static struct termios oldtio, newtio;
> +#endif /* HAVE_TERMIOS_H */
>  static int fd_out = 1;               /* output initially goes to
> standard output */ static char serbuf[255];
>  static int debug;
> --
> libgit2 0.26.0
>
>
>




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can’t measure it, you can’t improve it." - Lord Kelvin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]