[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gpsd-dev] [RFC] python client patch - reconnect to gpsd
From: |
Gary E. Miller |
Subject: |
Re: [gpsd-dev] [RFC] python client patch - reconnect to gpsd |
Date: |
Mon, 21 May 2018 17:47:10 -0700 |
Yo teyrana!
My bad. I should of not passed a patch without running scons check first.
jason: good catch!
Patch applied, tested, and pushed to git head.
On Sun, 20 May 2018 19:01:32 -0400
teyrana <address@hidden> wrote:
> Huh, that's odd. Well, my bad I guess.
>
> Anyway, here's a fix patch: (now passes 'scons check')
>
> https://pastebin.com/CCZrxJaY
>
>
> Daniel Williams
> address@hidden
> 858-220-8134 (Mobile)
> github.com/teyrana
> <https://github.com/teyrana>LinkedIn
> <https://www.linkedin.com/in/williamsdm>
>
> On Sun, May 20, 2018 at 3:01 PM, Jason Azze <address@hidden> wrote:
>
> > On Fri, May 18, 2018, at 6:19 PM, Gary E. Miller wrote:
> > > Yo teyrana!
> > >
> > > On Fri, 18 May 2018 17:56:40 -0400
> > > teyrana <address@hidden> wrote:
> > >
> > > > It looks like the client-reconnect code never made it into
> > > > master.
> > >
> > > Whoops. I had it in my current branch but forgot to push.
> > > Pushed now.
> > >
> > > Thanks for the reminder.
> >
> > I think something broke on this commit. All of my builders failed
> > scons check.
> >
> > 18:26:37 ./regress-driver -q test/daemon/passthrough.log
> > 18:26:37 Processing test/daemon/passthrough.log
> > 18:26:39 Traceback (most recent call last):
> > 18:26:39 File "/home/jenkins/workspace/gpsd_
> > multiplatform/slave/pelican2/gpsfake", line 261, in <module>
> > 18:26:39 test.run()
> > 18:26:39 File "/home/jenkins/workspace/gpsd_
> > multiplatform/slave/pelican2/gps/fake.py", line 749, in run
> > 18:26:39 while chosen.waiting():
> > 18:26:39 File "/home/jenkins/workspace/gpsd_
> > multiplatform/slave/pelican2/gps/client.py", line 90, in waiting
> > 18:26:39 (self.sock,), (), (), timeout)
> > 18:26:39 TypeError: argument must be an int, or have a fileno()
> > method. 18:26:39 Output missing for test/daemon/passthrough.log
> > 18:26:39 Regression test FAILED: 1 errors in 1 tests total (0 not
> > found). 18:26:39 The following test Failed:
> > 18:26:39
> > ================================================================
> > 18:26:39 "test/daemon/passthrough.log" 18:26:39
> > ================================================================
> > 18:26:39 scons: *** [gpsfake-pty] Error 1
> >
> >
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1 541 382 8588
Veritas liberabit vos. -- Quid est veritas?
"If you can’t measure it, you can’t improve it." - Lord Kelvin
pgpwJKTV3pWgm.pgp
Description: OpenPGP digital signature