gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gpsd-dev] RFC: GPSd on Android as a system service


From: Adam Serbinski
Subject: Re: [gpsd-dev] RFC: GPSd on Android as a system service
Date: Thu, 02 May 2019 19:17:05 -0400
User-agent: K-9 Mail for Android

Thanks, Gary.

Adam

On May 2, 2019 12:23:29 p.m. EDT, "Gary E. Miller" <address@hidden> wrote:
Yo A.S.!

Whoops. Pushed to git head.

I'm constantly finding little bugs like this in gpsd. Amazing how few
get noticed by users...

On Thu, 2 May 2019 07:54:57 -0400
"A.S." <address@hidden> wrote:

Another minor adjustment for the Android HAL. Use eph instead of epv
for horizontal accuracy.

https://gitlab.com/uploads/-/system/temp/df7f12f483f47f66f58b17a70f005e28/0001-Android-Use-eph-for-source-of-horizontal-accuracy.patch


On Mon, Apr 29, 2019 at 5:17 PM Gary E. Miller <address@hidden> wrote:

Yo A.S.!

Yeah, trivial, but important. Pushed to git head.

On Sun, 28 Apr 2019 20:29:36 -0400
"A.S." <address@hidden> wrote:

Blank line at the end of a file... well, some software insists on
it, and others complain about it.

Here is a very trivial change needed to make it build on AOSP
master branch;


https://gitlab.com/uploads/-/system/temp/9e979cbc9099c6d68128524f8e2e61d5/0001-Android-fix-build-on-AOSP-master.patch



On Sat, Apr 27, 2019 at 9:26 PM Gary E. Miller <address@hidden>
wrote:
Yo A.S.!

Nice. Thanks! ushed to git head.

I'm still getting whitepsace errors:

# git am -s 0001-Android-GNSS-1.1-HAL.patch
Applying: Android: GNSS 1.1 HAL
.git/rebase-apply/patch:232: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Not sure what that one means...

On Sat, 27 Apr 2019 21:18:06 -0400
"A.S." <address@hidden> wrote:

I've got another one for you.
This is a working GNSS HAL for Android, with init scripts, a
wrapper for gpsd to be able to log to Android's logging
server, and selinux policy.



https://gitlab.com/uploads/-/system/temp/d7552acf9c3941b93b2209ff5af9b2e4/0001-Android-GNSS-1.1-HAL.patch


On Thu, Apr 25, 2019 at 3:27 PM Gary E. Miller
<address@hidden> wrote:
Yo A.S.!

Both clean. Both pushed to git head. Thanks!

On Thu, 25 Apr 2019 15:20:16 -0400
"A.S." <address@hidden> wrote:

Correct. Just the last two.

On Thu, Apr 25, 2019 at 3:19 PM Gary E. Miller
<address@hidden> wrote:
Yo A.S.!

On Thu, 25 Apr 2019 15:09:32 -0400
"A.S." <address@hidden> wrote:

Last one for today, I promise

Feel free to keep them coming.





https://gitlab.com/uploads/-/system/temp/4effc380fb82a034995e9654f1a33977/0001-Android-clean-genrule-for-maskdump.c.patch


So this one, and the last one, ignoring the frist two of
today?


On Thu, Apr 25, 2019 at 2:28 PM A.S.
<address@hidden> wrote:
Everything that is built or generated is all
entirely out of tree. Android never makes any
changes in the source tree.

On Thu, Apr 25, 2019 at 2:26 PM Gary E. Miller
<address@hidden> wrote:
Yo A.S.!

On Thu, 25 Apr 2019 14:21:52 -0400
"A.S." <address@hidden> wrote:

No they don't. Android doesn't generate them in
the same tree as the original source.

Where "platform" is the Android build root,
GPSd source will be located at
platform/external/gpsd/ But all of the generated
files will be located in
platform/out/soong/.intermediates/external/gpsd/

So all out of tree?





On Thu, Apr 25, 2019 at 2:16 PM Gary E. Miller
<address@hidden> wrote:
Yo A.S.!

Cool, my procrastination pays off again.

Now that you generate these files:

[
+ "gpsd_timebase_h",
+ "gpsd_revision_h",
+ "gpsd_config_h",
+ "gpsd_packet_names_h"
+ generated_sources: ["gps_maskdump_c"],

They need to be in .gitignore.

Generating the files will prevent a lot of
bitrot.

On Thu, 25 Apr 2019 14:09:33 -0400
"A.S." <address@hidden> wrote:

Actually, scratch the last two and just use
this one. It does everything the last two
did, with a bit of simplification.







https://gitlab.com/uploads/-/system/temp/bf98672630341498e66e9dd5851a81cf/0001-Android-generate-headers.patch





On Thu, Apr 25, 2019 at 1:45 PM A.S.
<address@hidden> wrote:
And one more, to generate gps_maskdump.c;








https://gitlab.com/uploads/-/system/temp/2f87ce1d3dbec64e21f61bf3912a5612/0001-Android-Generate-gps_maskdump.c.patch





On Thu, Apr 25, 2019 at 1:08 PM A.S.
<address@hidden> wrote:
Hi Gary,

It looks like everything worked perfectly.
However, I do have another patch for you.
Its not the HAL yet, but I think it
addresses most or all of the issues;








https://gitlab.com/uploads/-/system/temp/35d5e6a41bd0151c40bd7cc2451218dc/0001-Android-generate-needed-headers.patch




Now the headers are generated.


On Wed, Apr 24, 2019 at 6:29 PM Gary E.
Miller <address@hidden> wrote:
Yo A.S.!

On Wed, 24 Apr 2019 18:25:00 -0400
"A.S." <address@hidden> wrote:

Wow, that is great.

And we are glad the patch. Many have
wanted something like it.
I'm not sure why the patch didn't apply
cleanly, I think it may have been
damaged by feeding through the gitlab
"snippet".

Likely.

I'll test it out tomorrow morning.

Cool. No rush.

And I agree with all of your comments.
I will address them.

Good.

Also note that I've made some good
progress with the Android GNSS HAL.
There is still some work to do, but it
is now working, so in a few days I
should have another patch for you.

Looking forward to it.

RGDS
GARY










Gary E. Miller Rellim 109 NW Wilmington
Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1 541 382 8588

Veritas liberabit vos. --
Quid est veritas? "If you can’t measure
it, you can’t improve it." - Lord
Kelvin





RGDS
GARY








Gary E. Miller Rellim 109 NW Wilmington Ave.,
Suite E, Bend, OR 97703 address@hidden Tel:+1
541 382 8588

Veritas liberabit vos. -- Quid est
veritas? "If you can’t measure it, you can’t
improve it." - Lord Kelvin




RGDS
GARY







Gary E. Miller Rellim 109 NW Wilmington Ave.,
Suite E, Bend, OR 97703 address@hidden Tel:+1 541
382 8588

Veritas liberabit vos. -- Quid est
veritas? "If you can’t measure it, you can’t
improve it." - Lord Kelvin





RGDS
GARY





Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E,
Bend, OR 97703 address@hidden Tel:+1 541 382 8588

Veritas liberabit vos. -- Quid est veritas?
"If you can’t measure it, you can’t improve it." -
Lord Kelvin




RGDS
GARY



Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E,
Bend, OR 97703 address@hidden Tel:+1 541 382 8588

Veritas liberabit vos. -- Quid est veritas?
"If you can’t measure it, you can’t improve it." - Lord
Kelvin




RGDS
GARY


Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR
97703 address@hidden Tel:+1 541 382 8588

Veritas liberabit vos. -- Quid est veritas?
"If you can’t measure it, you can’t improve it." - Lord
Kelvin




RGDS
GARY
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR
97703 address@hidden Tel:+1 541 382 8588

Veritas liberabit vos. -- Quid est veritas?
"If you can’t measure it, you can’t improve it." - Lord Kelvin





RGDS
GARY
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
address@hidden Tel:+1 541 382 8588

Veritas liberabit vos. -- Quid est veritas?
"If you can’t measure it, you can’t improve it." - Lord Kelvin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]