gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A quartet of patches that might be useful for parts


From: Gary E. Miller
Subject: Re: A quartet of patches that might be useful for parts
Date: Thu, 23 Jan 2020 17:10:59 -0800

Yo James!

On Thu, 23 Jan 2020 12:11:35 -0800
James Browning <address@hidden> wrote:

> Sorted roughly into patches by type of change after the fact.

Patch 2 applied, after fixing one problem:

-words, depending upon message type.</para>
+words, depending the upon message type.</para>

Patch 3 failed to apply:

    Applying: man: gpsd_json: droid assisted mistakes, scrap
    error: patch failed: man/gpsd_json.xml:418
    error: man/gpsd_json.xml: patch does not apply
    Patch failed at 0001 man: gpsd_json: droid assisted mistakes, scrap

MRs don't have the weird issues that email patches do.

Plus, it had some issues.

The problem with moving commas is that we don't have a style guide for
them and no two people will agree on comma placement.  So usually best
to leave them be.  I bet someone eveuntaully puts many of them back.

You missed the obvious error here:

-<para>Invalid or known floating point values will be set to NAN.
+<para>Invalid or known floating-point values will be set to NAN.

Fixed.  "un"known.

I removed this:

-        <entry>Signal to Noise ratio in dBHz.</entry>
+        <entry>Signal to Noise ratio in dB.</entry>

dBHz is correct.

And I prefer the original here:

-       in which device responses aren't tagged. Has no effect when
+       in which device responses aren't tagged. Does not affect when
        used with enable:false.</entry>

Patch 4 applied, but it was marginal.  No real content changes, just
a debatable change in emphasis.

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

Attachment: pgprKR8GCO_CZ.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]