Re: [PATCH 0/3] Cross build nitpicks

[Ladislav Michl]

On Sun, Feb 02, 2020 at 10:21:06AM +0100, Ladislav Michl wrote:
> Hello there,
> 
> following two changes makes gpsd fit better for my crosscompile
> use case...

There is one more issue; setting LD makes python extension fail to link
(paths shortened):
[..]/arm-v7a-linux-gnueabihf/bin/ld: 
[..]/sysroot-arm-v7a-linux-gnueabihf/usr/lib/crt1.o: in function `_start':
[..]/glibc-2.30/csu/../sysdeps/arm/start.S:119: undefined reference to `main'
[..]/arm-v7a-linux-gnueabihf/bin/ld: 
gpspacket-py_3_7_3_final_0.cpython-37m-arm-linux-gnueabihf.so: in function 
`Lexer_reset':
/home/ladis/src/gpsd/gpspacket.c:121: undefined reference to `PyErr_Occurred'
...etc

Can be fixed this way:
--- a/SConstruct
+++ b/SConstruct
@@ -525,8 +525,6 @@ for i in ["AR", "CC", "CXX", "LD",
           "PKG_CONFIG", "STRIP", "TAR"]:
     if i in os.environ:
         j = i
-        if i == "LD":
-            i = "SHLINK"
         env[i] = os.getenv(j)
 for i in ["ARFLAGS",
           "CCFLAGS",

It was added with 12f7ea1096 ("Allow to override variosu tools from
the environment."). Bernd, care to elaborate why is setting env['LD']
skipped?

Of course, this problem can be avoided by setting environment more
carefully, it is just surprising setting LD breaks the build.

Thank you,
        ladis