Re: gpsd | Pipeline #135104296 has failed for master | b30ab488

[Gary E. Miller]

Yo Bernd!

Thanks!

On Mon, 4 May 2020 15:23:50 +0200
Bernd Zeimetz <address@hidden> wrote:

> On 4/13/20 8:52 PM, Gary E. Miller wrote:
> 
> > sparc64 binary debugging is not in my skill set.  If no one that
> > has that skill cares, I'll just mark that to be ignored.  
> 
> Running gpsfake with python3 actually shows the issue:
> 
> Traceback (most recent call last):
>   File "/srv/bzed/gpsd/gpsfake", line 285, in <module>
>     test.gps_add(logfile, speed=speed, pred=fakehook,
>   File "/srv/bzed/gpsd/gps/fake.py", line 652, in gps_add
>     testload = TestLoad(logfile, predump=self.predump, slow=self.slow,
>   File "/srv/bzed/gpsd/gps/fake.py", line 168, in __init__
>     (plen, ptype, packet, _counter) = getter.get(logfp.fileno())
>   File "/srv/bzed/gpsd/gps/packet.py", line 155, in get
>     packet += chr(_loaded.outbuffer[octet])
> IndexError: invalid index
> 
> 
> The reason here is obvious:
> 
> _buffer_size = ctypes.c_int.in_dll(_packet, "fvi_size_buffer").value
> 
> 
> fvi_size_buffer is size_t and not an int, so _buffer_size was 0
> instead of MAX_PACKET_LENGTH *2+1.
> 
> 
> Fixed by
> 
> commit 4895c1a52122df948f4d2a9e266ea040f561d032
> Author: Bernd Zeimetz <address@hidden>
> Date:   Mon May 4 14:49:42 2020 +0200
> 
>     fvi_size_lexer/fvi_size_buffer are size_t.
> 
> 
> 
> 




RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        address@hidden  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

pgpA9XBqwthEG.pgp
Description: OpenPGP digital signature