[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: How to contribute
From: |
Gary E. Miller |
Subject: |
Re: How to contribute |
Date: |
Wed, 21 Oct 2020 10:37:32 -0700 |
Yo Martin!
On Wed, 21 Oct 2020 18:13:44 +0200
Martin Laabs <Martin.Laabs@tu-dresden.de> wrote:
> I made a fix to the ubxtool as it crashes with the -t option(s) with
> the current de-bundeling.
Thanks, the move to argparse and moving class ubx into the python module
was not as smooth as it should have been.
> There is also a bug with the OPTSVAR
> environmental variable I am gonna fix.
Uh, ubxtool does not use OPTSVAR for anything. Intentionally.
It does use UBXOPTS, maybe you mean that?
> What is the preferred way from
> the gpsd to include the fixes? Shall I make a merge request?
You can send diffs here to the mailing list, "git send-email" can make
that easy. Or create a merge request on GitLab. Which you use is personal
preference.
I just ask for more and smaller patches instead of one massive one. That
way I can merge the easy stuff right away as we discuss the harder stuff.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
gem@rellim.com Tel:+1 541 382 8588
Veritas liberabit vos. -- Quid est veritas?
"If you can't measure it, you can't improve it." - Lord Kelvin
pgpvpe7K6gljH.pgp
Description: OpenPGP digital signature